-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare repository for merge queue #36788
Comments
Note: "Skipping required jobs that are PR-specific" should be done as in core#11810, not core#11797, ie. we should make sure to enable the |
Edited the list above to mention that, thanks Jade! |
#### Description We've noticed that many of the CI failures on main come from Windows e2e tests. We want to be more proactive in catching those failures, so this PR changes the workflow triggering Windows e2e tests to ensure they run on Pull Requests that change Windows-related files, even if the label `Run Windows` is absent. It does so by looking at changed files. If the word `windows` is present in the file name, it triggers the workflow. #### Link to tracking issue Related to #36788 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
…emetry#36857) #### Description We've noticed that many of the CI failures on main come from Windows e2e tests. We want to be more proactive in catching those failures, so this PR changes the workflow triggering Windows e2e tests to ensure they run on Pull Requests that change Windows-related files, even if the label `Run Windows` is absent. It does so by looking at changed files. If the word `windows` is present in the file name, it triggers the workflow. #### Link to tracking issue Related to open-telemetry#36788 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
While looking at the automation for pinging codeowners, I've noticed there's a tool for this already: https://github.com/open-telemetry/opentelemetry-go-build-tools/tree/main/issuegenerator Has this been tested/enabled somewhere? How was the experience with it? |
…emetry#36857) #### Description We've noticed that many of the CI failures on main come from Windows e2e tests. We want to be more proactive in catching those failures, so this PR changes the workflow triggering Windows e2e tests to ensure they run on Pull Requests that change Windows-related files, even if the label `Run Windows` is absent. It does so by looking at changed files. If the word `windows` is present in the file name, it triggers the workflow. #### Link to tracking issue Related to open-telemetry#36788 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
I don't see any current mentions of issuegenerator other than in go.mods: https://github.com/search?q=org%3Aopen-telemetry+issuegenerator&type=code 🤔 |
Component(s)
No response
Describe the issue you're reporting
We have been testing the merge queue in opentelemetry-collector-releases and opentelemetry-collector. Once we have figured out how things should be set up, it has mostly worked fine. This issue is to set things up correctly to be able to use a merge queue:
merge_group
merge_group
trigger to required workflows opentelemetry-collector#11764, we already have it in some placeschangelog
workflow in merge queue opentelemetry-collector#11810 (and Fix merge queue CI opentelemetry-collector#11797)The text was updated successfully, but these errors were encountered: