Trigger windows e2e tests when windows-related files change #36857
Conversation
…file Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
|
/label "Skip changelog" |
songy23
added
ci-cd
If I understand correctly, merge queues only run workflows marked as required on PRs. That means that we'd need to run windows tests on every PR, right? |
I'm not sure, but my understanding is that it's not required. We could make Windows tests be required on merge queue but not run them for every PR. @mx-psi @jade-guiton-dd please correct me |
Arthur is correct that required is an all-or-nothing feature (so, the job would be mark as required in both the merge queue and PRs or in neither) BUT you can skip required jobs, so we could have logic to skip them on PRs |
…emetry#36857) #### Description We've noticed that many of the CI failures on main come from Windows e2e tests. We want to be more proactive in catching those failures, so this PR changes the workflow triggering Windows e2e tests to ensure they run on Pull Requests that change Windows-related files, even if the label `Run Windows` is absent. It does so by looking at changed files. If the word `windows` is present in the file name, it triggers the workflow. #### Link to tracking issue Related to open-telemetry#36788 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
Description
We've noticed that many of the CI failures on main come from Windows e2e tests. We want to be more proactive in catching those failures, so this PR changes the workflow triggering Windows e2e tests to ensure they run on Pull Requests that change Windows-related files, even if the label
Run Windowsis absent.It does so by looking at changed files. If the word
windowsis present in the file name, it triggers the workflow.Link to tracking issue
Related to #36788