Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/splunkhecexporter] Adding splunkhecexporter integration tests #23637

Merged
merged 43 commits into from
Oct 27, 2023
Merged

[exporter/splunkhecexporter] Adding splunkhecexporter integration tests #23637

merged 43 commits into from
Oct 27, 2023

Conversation

pszkamruk-splunk
Copy link
Contributor

@pszkamruk-splunk pszkamruk-splunk commented Jun 22, 2023 •
edited
Loading

Description:
Add a test suite to the opentelemetry-contrib repository that checks the behavior of the HEC exporter against a Splunk Enterprise instance.

Link to tracking Issue:
N/A

Testing:
added HEC exporter integration tests

Documentation:
no changes needed

Changelog - Skip ChangeLog
change doesn't affect end users

@pszkamruk-splunk pszkamruk-splunk requested a review from a team June 22, 2023 12:30
@github-actions github-actions bot requested a review from pmcollins June 22, 2023 12:30
@pszkamruk-splunk pszkamruk-splunk changed the title [chore] [exporter/splunkhec] Adding splunkhecexporter integration tests [exporter/splunkhecexporter] Adding splunkhecexporter integration tests Jun 22, 2023
@pszkamruk-splunk pszkamruk-splunk mentioned this pull request Jun 22, 2023
Closed
@pszkamruk-splunk
Copy link
Contributor Author

integration tests timeouts due to low timeout value (6mins), I have pushed commit with increased timeout value to check if it will help

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 25, 2023
@dmitryax dmitryax removed the Stale label Jul 25, 2023
@dmitryax
Copy link
Member

dmitryax commented Oct 5, 2023

@pszkamruk-splunk please run make gotidy to have the check job pass

@dmitryax
Copy link
Member

dmitryax commented Oct 9, 2023

@pszkamruk-splunk did you see the integration CI job pass in this PR? It's failing on a different test, but I believe this PR somehow affects it. I don't see this failure on other PRs

@pszkamruk-splunk
Copy link
Contributor Author

pszkamruk-splunk commented Oct 9, 2023 •
edited
Loading

@dmitryax yes tests were passing some time ago
I am not sure if this issue is related, but it might be as in splunkhecexporter tests I am downloading and starting Splunk docker image (~2GB )
I have pushed a commit where image is being removed after tests execution
on fork repo integration tests are passing now

  • and still I am getting lokireceiver and opencensusreceiver mod.go and sum.go files changed by make gotidy (I have not added these files into PR)

@pszkamruk-splunk
Copy link
Contributor Author

@dmitryax there is no more no space left on device error in tests
although tests are still failing
this time: receiver/sqlqueryreceiver - timeout (6m) while waiting for container
this is probably not related to my PR, I have rerun whole integration test pipeline on my fork repo and tests are passing there, can we rerun pipeline?

@pszkamruk-splunk
Copy link
Contributor Author

@dmitryax @MovieStoreGuy
could you please trigger pipeline
I have merged latest main,
I have also run make gotidy -> it wants to change mod.go and sum.go files in lokireceiver and in opencensusreceiver, I have not added these files into PR as my changes are not related to these areas

pszkamruk-splunk and others added 9 commits October 20, 2023 09:03
@pszkamruk-splunk
Merge branch 'open-telemetry:main' into main
e601d8b
@pszkamruk-splunk
parent e601d8b
ec83dc0 
author Pawel Szkamruk <[email protected]> 1686664596 +0200
committer Pawel Szkamruk <[email protected]> 1697787968 +0200
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEEiLgqjUke5gZqdUhD8uKMOu/hMOoFAmUyMEAACgkQ8uKMOu/h
 MOpIhhAA0PgvHe7VbY163Va6Y/fhy7kFNmAP+i/OajYWiB3XYl5ROkNhMV2DPERS
 ZcpQ7/NnzzJsZyWoCqjZbNAKpSg/DflUStwGp37/zlQFxLFTU8EKdx9t1RivmI0S
 fH98323SZXDBEnyxZeOt6yTxBES/SpIExqwx9K0TmN16Ab96tYtwPSz9OC+N0Vlg
 iLMaJMupILFpE+KoP4gnaR7kFSn7BDx68LXbRqMveSipBKpiUT0r4C28uZgnLjRM
 vXBHVTujXkOf16R2I3pu2u//iDIt1tHkoi3W2yAgyQDFnuUVZr4k/9mayOaB0l0x
 qJKB9NjV8UoIOYS95dSNyA0RuwEWlfktb4vDcx//FMiMfSC0rTms5agyF47wyDMl
 zJpGXDzvFLS5hJ/NMqzMchGt4XI6AHheskRWzrk1b4j18oUUPcI30QBQKU1sb3Ma
 j/kezz4GTw1VdpUXkXC9PgvuTpXDI7+gFJzgSnfPRDw2vQEUQCbtQ2+/1+F8BqLB
 fbnjnrmhLfpuTDzYSNsaMk4AbVItoiSGLUdVMhyQmouwpXQXoamw1B5AA0u0HqLM
 nnsViOpCY5htDiVQ+icEBjIhf8yKCbGtquVGBUk1dqVBXC6uKDyYWGj4iqSv0nMC
 vT1Qf1JWaEO6ELMFKPj35TvnNUfdY5aoO7tt8WKseJZFBLZtzDs=
 =YHOz
 -----END PGP SIGNATURE-----

Splunk HEC exporter integration tests
@pszkamruk-splunk
Merge branch 'open-telemetry:main' into main
c8a4023
@pszkamruk-splunk
Merge branch 'main' into hec-exporter-integration-test-initial-branch
29a5eee
@pszkamruk-splunk
Merge branch 'open-telemetry:main' into main
ada4fda
@pszkamruk-splunk
Merge branch 'main' into hec-exporter-integration-test-initial-branch
8ed7b42
@pszkamruk-splunk
make gotidy
5d62df7
@pszkamruk-splunk
Merge branch 'open-telemetry:main' into main
d3eadfa
@pszkamruk-splunk
Merge branch 'main' into hec-exporter-integration-test-initial-branch
3ca599b
@dmitryax
Copy link
Member

Thanks @pszkamruk-splunk!

@dmitryax dmitryax merged commit c9b9e19 into open-telemetry:main Oct 27, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 27, 2023
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
@pszkamruk-splunk @sigilioso
[exporter/splunkhecexporter] Adding splunkhecexporter integration tes…
f1b5d42 
…ts (open-telemetry#23637)

**Description:**
Add a test suite to the opentelemetry-contrib repository that checks the
behavior of the HEC exporter against a Splunk Enterprise instance.
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@pszkamruk-splunk @jmsnll
[exporter/splunkhecexporter] Adding splunkhecexporter integration tes…
1cbfc94 
…ts (open-telemetry#23637)

**Description:**
Add a test suite to the opentelemetry-contrib repository that checks the
behavior of the HEC exporter against a Splunk Enterprise instance.
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
@pszkamruk-splunk @RoryCrispin
[exporter/splunkhecexporter] Adding splunkhecexporter integration tes…
29e7f84 
…ts (open-telemetry#23637)

**Description:**
Add a test suite to the opentelemetry-contrib repository that checks the
behavior of the HEC exporter against a Splunk Enterprise instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

@dmitryax dmitryax dmitryax approved these changes

@atoulme atoulme atoulme approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi

@pmcollins pmcollins Awaiting requested review from pmcollins

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@mar4uk mar4uk Awaiting requested review from mar4uk

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol exporter/splunkhec extension/observer receiver/loki receiver/opencensus receiver/splunkhec Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pszkamruk-splunk @atoulme @dmitryax @MovieStoreGuy