[receiver/statsd] Refactor of hardcoded tests #24832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Aug 5, 2023
| # you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: "bug_fix" |
There was a problem hiding this comment.
Is there a bug that fixed by this PR? If it's just refactoring, no changelog entry is needed
There was a problem hiding this comment.
I remove it on the commit #7094a68
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
kang-makes
force-pushed
the
receiver/statsdreceiver/add-uds-support
branch
from
59faed9 to
7094a68
Compare
|
Rebased :) |
kang-makes
force-pushed
the
receiver/statsdreceiver/add-uds-support
branch
from
7094a68 to
e4f8238
Compare
|
Rebased. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
kang-makes
force-pushed
the
receiver/statsdreceiver/add-uds-support
branch
from
e4f8238 to
4fa23ed
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
@dmitryax I have just rebased it and included in this PR the support for TCP that was added by the community. Let me know if I can do something more because I cannot reopen the PR :( |
bogdandrutu
pushed a commit
that referenced
this pull request
Dec 15, 2023
**Description:** This is the first step to adding UDS support to the StatsD receiver. As I started to develop it, I saw that all tests were hardcoded to UDP and using networking and there was no possibility to add a socket communication. PR started to get huge so I split it into two, one to refactor tests and another one that adds UDS support: * Removed all unused references. * Made a `Transport` helper that allows centralizing all supported protocols and constants in its package. * Removed all hardcoded UDP protocols and generalized testing so new protocols are easy to add. If you need a rationale about why the changes are like this, this is the next PR I am going to submit after this one is merged: kang-makes#2 That is the PR that is going to add UDS support properly. **Link to tracking Issue:** - #21385 **Previous closed PR:** - #24832
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…28896) **Description:** This is the first step to adding UDS support to the StatsD receiver. As I started to develop it, I saw that all tests were hardcoded to UDP and using networking and there was no possibility to add a socket communication. PR started to get huge so I split it into two, one to refactor tests and another one that adds UDS support: * Removed all unused references. * Made a `Transport` helper that allows centralizing all supported protocols and constants in its package. * Removed all hardcoded UDP protocols and generalized testing so new protocols are easy to add. If you need a rationale about why the changes are like this, this is the next PR I am going to submit after this one is merged: kang-makes#2 That is the PR that is going to add UDS support properly. **Link to tracking Issue:** - open-telemetry#21385 **Previous closed PR:** - open-telemetry#24832
This was referenced Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the first step to adding UDS support to the StatsD receiver.
As I started to develop it, I saw that all tests were hardcoded to UDP and using networking and there was no possibility to add a socket communication.
PR started to get huge so I split it into two, one to refactor tests and another one that adds UDS support:
Transporthelper that allows centralizing all supported protocols and constants in its package.If you need a rationale about why the changes are like this, this is the next PR I am going to submit after this one is merged: kang-makes#2
That is the PR that is going to add UDS support properly.
Link to tracking Issue: