Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/translator/azure] New component for translating from Azure native formats #25096

Merged

Conversation

cparkins
Copy link
Contributor

@cparkins cparkins commented Aug 8, 2023

Description:

Adding a Translator to convert from Azure Resource Log format (for now) to OTel.

Link to tracking Issue:
#18210

Testing:
Performed manual validation testing between Event Hubs and OTel and added unit tests to cover new use case to allow multiple resources to be included in a batch. Existing tests moved to new package.

Documentation:
None was necessary as this format is already supported by the Event Hub Receiver.

@cparkins cparkins requested a review from a team August 8, 2023 19:46
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command receiver/azureeventhub labels Aug 8, 2023
@github-actions github-actions bot requested a review from pmcollins August 8, 2023 19:47
@cparkins cparkins force-pushed the new_component/pkg/translator/azure branch from 2897344 to 40ad2df Compare August 15, 2023 19:02
@cparkins
Copy link
Contributor Author

@Aneurysm9 - I'd love to get a review of this now that the build is functioning. Next time I'll RTFM much earlier!

Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems reasonable to me, I will leave it to the code sponsers to have the final approval.

pkg/translator/azure/go.mod Outdated Show resolved Hide resolved
@jpkrohling
Copy link
Member

I will leave it to the code sponsers to have the final approval.

Is that @atoulme? I think I'm a sponsor for an Azure component, but not sure this here is part of that.

@cparkins cparkins force-pushed the new_component/pkg/translator/azure branch 2 times, most recently from 437d035 to 8fdf93c Compare September 7, 2023 20:07
@github-actions github-actions bot requested a review from mar4uk September 7, 2023 20:08
@cparkins
Copy link
Contributor Author

Sorry, there's just a couple things that caught my eye on second read. Please see my comments. We're very close.

Thanks! I reviewed the final set of changes and made those recommendations.

@mx-psi mx-psi merged commit baf4cce into open-telemetry:main Oct 25, 2023
87 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 25, 2023
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
…e formats (open-telemetry#25096)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Adding a Translator to convert from Azure Resource Log format (for now)
to OTel.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#18210

**Testing:** <Describe what testing was performed and which tests were
added.>
Performed manual validation testing between Event Hubs and OTel and
added unit tests to cover new use case to allow multiple resources to be
included in a batch. Existing tests moved to new package.

**Documentation:** <Describe the documentation added.>
None was necessary as this format is already supported by the Event Hub
Receiver.
@cparkins cparkins deleted the new_component/pkg/translator/azure branch October 27, 2023 19:22
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…e formats (open-telemetry#25096)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Adding a Translator to convert from Azure Resource Log format (for now)
to OTel.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#18210

**Testing:** <Describe what testing was performed and which tests were
added.>
Performed manual validation testing between Event Hubs and OTel and
added unit tests to cover new use case to allow multiple resources to be
included in a batch. Existing tests moved to new package.

**Documentation:** <Describe the documentation added.>
None was necessary as this format is already supported by the Event Hub
Receiver.
TylerHelmuth pushed a commit that referenced this pull request Nov 16, 2023
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In #25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <[email protected]>
graphaelli pushed a commit to graphaelli/opentelemetry-collector-contrib that referenced this pull request Nov 17, 2023
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <[email protected]>
aishyandapalli pushed a commit to aishyandapalli/opentelemetry-collector-contrib that referenced this pull request Nov 17, 2023
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <[email protected]>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…e formats (open-telemetry#25096)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Adding a Translator to convert from Azure Resource Log format (for now)
to OTel.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#18210

**Testing:** <Describe what testing was performed and which tests were
added.>
Performed manual validation testing between Event Hubs and OTel and
added unit tests to cover new use case to allow multiple resources to be
included in a batch. Existing tests moved to new package.

**Documentation:** <Describe the documentation added.>
None was necessary as this format is already supported by the Event Hub
Receiver.
jinja2 pushed a commit to jinja2/opentelemetry-collector-contrib that referenced this pull request Dec 18, 2023
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <[email protected]>
jinja2 pushed a commit to jinja2/opentelemetry-collector-contrib that referenced this pull request Dec 18, 2023
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <[email protected]>
jinja2 pushed a commit to jinja2/opentelemetry-collector-contrib that referenced this pull request Jan 16, 2024
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <[email protected]>
jinja2 pushed a commit to jinja2/opentelemetry-collector-contrib that referenced this pull request Jan 16, 2024
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants