[receiver/filelog] fix behavior of add operator when using env function #26374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
fix_os_env_func_add
branch
from
91fbb8b to
df3ed90
Compare
dmitryax
approved these changes
Sep 1, 2023
|
@atoulme, thanks for tracking down the problem and putting together a fix. I started putting together some feedback but ended up prototyping what I would suggest, so I just opened an alternative PR for this. Basically, I think the fix should be incorporated into the helper package in order to make it more standardized. I also think it's sufficient and better to localize the unit test to the operator. |
|
Closing in favor of #26467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the behavior of the add operator to continue to support EXPR(env("MY_ENV_VAR")) expressions
Link to tracking Issue:
#26373
Testing:
Unit test.