Switch from detecting faas.id to faas.instance in the gcp detector. #26486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/resourcedetection
dashpole
force-pushed
the
update_resource_detector
branch
from
8445ffe to
615783f
Compare
codeboten
reviewed
Sep 7, 2023
There was a problem hiding this comment.
I believe since this is an end-user impacting breaking change it should be done via feature-gates https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#end-user-impacting-changes
dashpole
force-pushed
the
update_resource_detector
branch
from
940b453 to
1b4abc1
Compare
|
@codeboten I added a feature gate, and changed the PR from |
dashpole
force-pushed
the
update_resource_detector
branch
from
1b4abc1 to
3c8dc69
Compare
dashpole
force-pushed
the
update_resource_detector
branch
2 times, most recently
from
419fff0 to
12417ee
Compare
|
@codeboten @dmitryax @Aneurysm9 PTAL if you have time. |
dashpole
added
the
ready to merge
|
Please resolve the conflict |
dashpole
force-pushed
the
update_resource_detector
branch
from
fd7704a to
84b5d76
Compare
|
@codeboten conflict resolved. |
Co-authored-by: Alex Boten <[email protected]>
|
@codeboten sorry. Forgot to pull in origin when I fixed go.mod |
codeboten
approved these changes
Oct 6, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…pen-telemetry#26486) Context: GoogleCloudPlatform/opentelemetry-operations-go#679 faas.id was removed from the semantic conventions: open-telemetry/opentelemetry-specification#3188 We were previously using it improperly to store the instance id of the faas, which should be mapped to faas.instance instead. --------- Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Context: GoogleCloudPlatform/opentelemetry-operations-go#679
faas.id was removed from the semantic conventions: open-telemetry/opentelemetry-specification#3188
We were previously using it improperly to store the instance id of the faas, which should be mapped to faas.instance instead.
Testing:
Unit tests