Refactor fault/error logic #26681
Merged
Refactor fault/error logic #26681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
refactor-fault-error-logic
branch
from
8e66ca7 to
9a32258
Compare
songy23
reviewed
Sep 14, 2023
| @@ -118,41 +118,34 @@ func makeCause(span ptrace.Span, attributes map[string]pcommon.Value, resource p | |||
| } | |||
| } | |||
|
|
|||
| // The logic to record error and fault should be kept in sync with the ADOT pulse repo whenever possible except for the throttle | |||
| // https://github.com/aws-observability/aws-apm-java-instrumentation/blob/main/awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsSpanMetricsProcessor.java | |||
pxaws
reviewed
Sep 15, 2023
| code = val.Int() | ||
| } | ||
|
|
||
| isThrottle = false |
There was a problem hiding this comment.
Can we have a default false value for isError and isFault as well? This can simplify the switch block.
pxaws
approved these changes
Sep 15, 2023
harrryr
force-pushed
the
refactor-fault-error-logic
branch
from
801e655 to
9704ad3
Compare
dmitryax
approved these changes
Sep 19, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** This PR just refactors the logic in the awsxrayexporter as it was hard to follow the logical flow of the code. No functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR just refactors the logic in the awsxrayexporter as it was hard to follow the logical flow of the code. No functional changes.
Link to tracking Issue:
Testing:
Ran unit tests
Ran integration test by creating eks cluster and activating sample app.
Documentation: