Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] Add 'overwrite_text' option to severity parser #27004

Merged

Conversation

djaglowski
Copy link
Member

Resolves #26671
Resolves #26718

@djaglowski djaglowski marked this pull request as ready for review September 20, 2023 13:28
@djaglowski djaglowski requested review from a team and bogdandrutu September 20, 2023 13:28
Mapping severityMap
ParseFrom entry.Field
Mapping severityMap
overwriteText bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only overwriteText is private, is it intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the whole struct could be unexported but I only tried to not increase the surface area with this change.

@djaglowski djaglowski merged commit ccfd8b1 into open-telemetry:main Sep 21, 2023
@djaglowski djaglowski deleted the pkg-stanza-severity-text-overwrite branch September 21, 2023 20:54
@github-actions github-actions bot added this to the next release milestone Sep 21, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
hanjm added a commit to hanjm/opentelemetry-collector-contrib that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants