Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/statsdreceiver] Gracefully handle empty tagset #27011

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

callumj
Copy link
Contributor

@callumj callumj commented Sep 19, 2023

Description:
We have a set of client libraries (com.timgroup.statsd.NonBlockingStatsDClient) that send a metric like this where there are no tags:

some_metric_name:1|c|#

Now the validity of this StatsD message can be questioned but the fact of the matter is this is widespread/common behavior for now. This PR includes a fix to move on if no tags in the array are present.

Link to tracking Issue:
None

Testing:
Added unit tests

Documentation:
N/A

@callumj callumj requested a review from a team September 19, 2023 21:08
@github-actions github-actions bot added the receiver/statsd statsd related issues label Sep 19, 2023
@codeboten codeboten merged commit a3aa0ef into open-telemetry:main Sep 22, 2023
91 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 22, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…try#27011)

We have a set of client libraries
(`com.timgroup.statsd.NonBlockingStatsDClient`) that send a metric like
this where there are no tags:

```
some_metric_name:1|c|#
```

Now the validity of this StatsD message can be questioned but the fact
of the matter is this is widespread/common behavior for now. This PR
includes a fix to move on if no tags in the array are present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/statsd statsd related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants