-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/awscontainerinsight] Filter terminated pods from node request metrics. #27299
[receiver/awscontainerinsight] Filter terminated pods from node request metrics. #27299
Conversation
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Lint failure needs to be fixed. |
Yep. The linting must've changed at some point. Will update it. |
The lint failure has been fixed. |
Description: The
node_<cpu|memory>_request
metrics and metrics derived from them (node_<cpu|memory>_reserved_capacity
) differ from the output ofkubectl describe node <node_name>
. This is because kubectl filters out terminated pods. See linked issue for more details.Adds a filter for terminated (succeeded/failed state) pods.
Link to tracking Issue: #27262
Testing: Added unit test to validate pod state filtering. Built and deployed changes to cluster. Deployed
cpu-test
pod.The gap is when the change was deployed. The metric drops after the deployment due to the filter. The metric can be seen spiking up while the
cpu-test
pod is running (~19:15) and then returns to the previous request size after it has terminated.Documentation: N/A