Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] sqlserverreceiver/Add run as admin to docs #27452

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

kuiperda
Copy link
Contributor

@kuiperda kuiperda commented Oct 5, 2023

Description:
Added a line explaining to run collector as admin, since not all perf counters are collected unless you do.
(Or I'm missing something, which should be documented)

Testing: No unit tests, but observed this with a simple collector install on windows.

Documentation: See above.

@kuiperda kuiperda requested a review from djaglowski as a code owner October 5, 2023 19:48
@kuiperda kuiperda requested a review from a team October 5, 2023 19:48
@github-actions github-actions bot requested a review from StefanKurek October 5, 2023 19:48
@kuiperda kuiperda changed the title Add run as admin suggestion sqlserverreceiver/Add run as admin to docs Oct 5, 2023
@kuiperda kuiperda changed the title sqlserverreceiver/Add run as admin to docs [chore] sqlserverreceiver/Add run as admin to docs Oct 5, 2023
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 5, 2023
@codeboten codeboten merged commit 37233ae into open-telemetry:main Oct 5, 2023
87 of 88 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 5, 2023
@kuiperda kuiperda deleted the sqlserver/update-readme branch October 6, 2023 18:57
@kuiperda kuiperda restored the sqlserver/update-readme branch October 12, 2023 20:24
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
)

**Description:** 
Added a line explaining to run collector as admin, since not all perf
counters are collected unless you do.
(Or I'm missing something, which should be documented)

**Testing:** No unit tests, but observed this with a simple collector
install on windows.

**Documentation:** See above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/sqlserver Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants