[receiver/azuremonitor]: Support Azure gov cloud #27573
Conversation
| @@ -20,6 +20,10 @@ var ( | |||
| errMissingClientID = errors.New(`ClientID" is not specified in config`) | |||
| errMissingClientSecret = errors.New(`ClientSecret" is not specified in config`) | |||
| errMissingFedTokenFile = errors.New(`FederatedTokenFile is not specified in config`) | |||
| errInvalidCloud = errors.New(`Cloud" is invalid`) | |||
|
|
|||
| azureCloud = "AzureCloud" | |||
There was a problem hiding this comment.
I am not sure these are the preferred names, but these are the names returned from running az cloud list. Other tools use different conventions (e.g. terraform).
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@codeboten @altuner can I get some feedback on this? |
| @@ -18,6 +18,7 @@ import ( | |||
|
|
|||
| const ( | |||
| defaultCollectionInterval = 10 * time.Second | |||
| defaultCloud = "AzureCloud" | |||
There was a problem hiding this comment.
please use const "azureCloud" from config here
There was a problem hiding this comment.
Had to move config vars to constants. Let me know if that doesn't work
| @@ -45,6 +45,7 @@ func TestNewFactory(t *testing.T) { | |||
| CacheResourcesDefinitions: 24 * 60 * 60, | |||
| MaximumNumberOfMetricsInACall: 20, | |||
| Authentication: servicePrincipal, | |||
| Cloud: azureCloud, | |||
| ```yaml | ||
| receivers: | ||
| azuremonitor: | ||
| subscription_id: "${subscription_id}" | ||
| tenant_id: "${tenant_id}" | ||
| client_id: "${client_id}" | ||
| client_secret: "${env:CLIENT_SECRET}" | ||
| cloud: AzureUSGovernment |
There was a problem hiding this comment.
should we put here default one?
There was a problem hiding this comment.
Not sure. I wouldn't expect users to include this line at all when configuring the public cloud. They can also infer this from the bullets above but I thought a more complete example was nice. Happy to use the default tho if you think that makes sense.
There was a problem hiding this comment.
@altuner just following up here and with the other changes.
|
@altuner @codeboten sorry to keep pinging but I would love to move this along so that I can use it in my collector. Anything I can do to make that happen please let me know! |
Co-authored-by: Alex Boten <[email protected]>
Support Azure gov cloud **Testing:** Ran against a government subscription --------- Co-authored-by: Alex Boten <[email protected]>
Support Azure gov cloud **Testing:** Ran against a government subscription --------- Co-authored-by: Alex Boten <[email protected]>
Description:
Support Azure gov cloud
Link to tracking Issue: N/A
Testing: Ran against a government subscription
Documentation: Updated README