[internal/kafka] define a common validation function for kafka authentication #27674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakulali
force-pushed
the
add-kafka-validate-authentication
branch
from
2bb80f9 to
21203ce
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
sakulali
force-pushed
the
add-kafka-validate-authentication
branch
from
21203ce to
931b186
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
sakulali
force-pushed
the
add-kafka-validate-authentication
branch
from
931b186 to
9269f73
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
sakulali
force-pushed
the
add-kafka-validate-authentication
branch
from
9269f73 to
49b5f01
Compare
Signed-off-by: sakulali <[email protected]>
sakulali
force-pushed
the
add-kafka-validate-authentication
branch
from
49b5f01 to
91b70ec
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Define a common validation function for kafka authentication, which can be reused by kafkametricsreceiver, kafkareceiver and kafkaexporter. In addition, extract redundant validation logic between the validateSASLConfig and configureSASL functions.
Link to tracking Issue:
#27486
Testing:
make chlog-validate
go test for internal/kafka
go test for kafkaexporter
go test for kafkametricsreceiver
go test for kafkareceiver
Documentation: