[connector/spanmetrics] Fix memory leak #28847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bripkens
force-pushed
the
fix-spanmetrics-memory-leak
branch
from
8137649 to
cd81af5
Compare
bripkens
force-pushed
the
fix-spanmetrics-memory-leak
branch
from
cd81af5 to
8dc2eac
Compare
bripkens
changed the title
bripkens
force-pushed
the
fix-spanmetrics-memory-leak
branch
from
8dc2eac to
2c2baa6
Compare
crobert-1
reviewed
Nov 1, 2023
bripkens
force-pushed
the
fix-spanmetrics-memory-leak
branch
from
2c2baa6 to
c64fb77
Compare
atoulme
reviewed
Nov 13, 2023
albertteoh
approved these changes
Nov 13, 2023
| @@ -74,3 +74,17 @@ func (c *Cache[K, V]) Purge() { | |||
| c.lru.Purge() | |||
| c.RemoveEvictedItems() | |||
| } | |||
|
|
|||
| // ForEach iterates over all the items within the cache, as well as the evicted items (if any). | |||
| func (c *Cache[K, V]) ForEach(fn func(k K, v V)) { | |||
albertteoh
reviewed
Nov 13, 2023
bripkens
force-pushed
the
fix-spanmetrics-memory-leak
branch
from
c64fb77 to
e929f8b
Compare
albertteoh
approved these changes
Nov 14, 2023
mfilipe
approved these changes
Nov 27, 2023
atoulme
approved these changes
Nov 27, 2023
JaredTan95
reviewed
Dec 4, 2023
|
need to fix https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7083411340/job/19275795975#step:8:148: Error: ./connector_test.go:901:146: not enough arguments in call to newConnectorImp
have (*testing.T, consumertest.Consumer, *string, func() HistogramConfig, func() ExemplarsConfig, string, *zap.Logger, nil)
want (*testing.T, consumer.Metrics, *string, func() HistogramConfig, func() ExemplarsConfig, func() EventsConfig, string, *zap.Logger, *clock.Ticker, ...string) (typecheck) |
# Why The `spanmetrics` connector has a memory leak that occurs when the cumulative temporality is used. The `connectorImp#resourceMetrics` map is only ever cleaned up in delta temporality. # What Turn `connectorImp#resourceMetrics` into a LRU cache with a maximum size. To correctly handle metric resets we also introduce a start timestamp per `resourceMetric` instance. # References Fixes open-telemetry#27654 Co-authored-by: Jared Tan <[email protected]>
bripkens
force-pushed
the
fix-spanmetrics-memory-leak
branch
from
3eaa2aa to
7ff7b54
Compare
|
done @JaredTan95 |
atoulme
approved these changes
Dec 5, 2023
TylerHelmuth
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
spanmetricsconnector has a memory leak that occurs when the cumulative temporality is used. TheconnectorImp#resourceMetricsmap is only ever cleaned up in delta temporality.What
Turn
connectorImp#resourceMetricsinto a LRU cache with a maximum size. To correctly handle metric resets we also introduce a start timestamp perresourceMetricinstance.References
Fixes #27654