Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector/spanmetrics] fix(docs): add example of R.E.D metrics for span data #29115

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[connector/spanmetrics] fix(docs): add example of R.E.D metrics for span data #29115

merged 2 commits into from
Nov 23, 2023

Conversation

karmingc
Copy link
Contributor

@karmingc karmingc commented Nov 12, 2023 •
edited
Loading

Description: This is to clarify the metrics name generated.

Link to tracking Issue: 26520

Testing: n/a docs

Documentation: n/a

@karmingc karmingc requested review from a team and atoulme November 12, 2023 01:50
@songy23 songy23 added documentation Improvements or additions to documentation Skip Changelog PRs that do not require a CHANGELOG.md entry labels Nov 12, 2023
albertteoh
albertteoh approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpkrohling jpkrohling merged commit accfdcc into open-telemetry:main Nov 23, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 23, 2023
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
@karmingc @RoryCrispin
[connector/spanmetrics] fix(docs): add example of R.E.D metrics for s…
c1a365e 
…pan data (open-telemetry#29115)

**Description:** This is to clarify the metrics name generated.

**Link to tracking Issue:**
[26520](open-telemetry#26520)

**Testing:** n/a docs

**Documentation:** n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertteoh albertteoh albertteoh approved these changes

@songy23 songy23 songy23 approved these changes

@atoulme atoulme Awaiting requested review from atoulme

@JaredTan95 JaredTan95 Awaiting requested review from JaredTan95

Assignees

@jpkrohling jpkrohling

Labels
connector/spanmetrics documentation Improvements or additions to documentation Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@karmingc @songy23 @JaredTan95 @albertteoh @jpkrohling