-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/resourcedetection] Add feature gate to change family and model to string #29152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/resourcedetection
Resource detection processor
label
Nov 13, 2023
ChrsMark
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank's for covering this! The change LGTM.
dashpole
approved these changes
Nov 13, 2023
songy23
approved these changes
Nov 13, 2023
songy23
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Nov 13, 2023
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…odel to string (open-telemetry#29152) **Description:** Add feature gate to change family and CPU model to string, to adapt to open-telemetry/semantic-conventions/issues/495. **Link to tracking Issue:** Fixes open-telemetry#29025 **Testing:** Tested with the sample configuration on open-telemetry#26533.
mx-psi
added a commit
that referenced
this pull request
Nov 30, 2023
…ostCPUModelAndFamilyAsString` to beta (#29462) **Description:** Follow up to #29152. The feature gate has been in alpha for two releases (v0.89.0 and v0.90.0). **Link to tracking Issue:** Relates to #29025 and to open-telemetry/semantic-conventions/issues/495. **Testing:** Tested with the sample configuration on #26533.
mx-psi
added a commit
that referenced
this pull request
May 17, 2024
…PUModelAndFamilyAsString` feature gate to stable (#33077) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Follows #29152 and #29462. The feature gate has been in beta since v0.91.0. **Link to tracking Issue:** Relates to #29025 and to open-telemetry/semantic-conventions#495
mx-psi
pushed a commit
that referenced
this pull request
Sep 16, 2024
…CPUModelAndFamilyAsString feature gate (#35203) Description: Follows #33077, #29152 and #29462. The feature gate has been stable since v0.101.0. Link to tracking Issue: Relates to #29025 and to open-telemetry/semantic-conventions#495 /cc @mx-psi --------- Signed-off-by: ChrsMark <[email protected]>
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…CPUModelAndFamilyAsString feature gate (open-telemetry#35203) Description: Follows open-telemetry#33077, open-telemetry#29152 and open-telemetry#29462. The feature gate has been stable since v0.101.0. Link to tracking Issue: Relates to open-telemetry#29025 and to open-telemetry/semantic-conventions#495 /cc @mx-psi --------- Signed-off-by: ChrsMark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
processor/resourcedetection
Resource detection processor
ready to merge
Code review completed; ready to merge by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add feature gate to change family and CPU model to string, to adapt to open-telemetry/semantic-conventions/issues/495.
Link to tracking Issue: Fixes #29025
Testing: Tested with the sample configuration on #26533.