Limit the number of exemplars to be added for each dimension set #29242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishyandapalli
force-pushed
the
span-metrics-oom-fix
branch
from
8cffe98 to
a782206
Compare
albertteoh
reviewed
Nov 17, 2023
aishyandapalli
force-pushed
the
span-metrics-oom-fix
branch
4 times, most recently
from
9112a8f to
58c1c2f
Compare
albertteoh
reviewed
Dec 1, 2023
connector/spanmetricsconnector/internal/metrics/metrics_test.go
Outdated
Show resolved
Hide resolved
connector/spanmetricsconnector/internal/metrics/metrics_test.go
Outdated
Show resolved
Hide resolved
connector/spanmetricsconnector/internal/metrics/metrics_test.go
Outdated
Show resolved
Hide resolved
aishyandapalli
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
dashpole,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
jpkrohling,
Aneurysm9,
TylerHelmuth,
mx-psi,
bogdandrutu,
evan-bradley,
tigrannajaryan,
jsuereth,
arminru and
songy23
as code owners
github-actions
bot
added
exporter/awsemf
|
@aishyandapalli It looks like some unrelated changes got attached to your branch. Could you take a look? If practical, squashing all of your changes into a single commit and rebasing on main may help remove the extra commits. |
aishyandapalli
force-pushed
the
span-metrics-oom-fix
branch
3 times, most recently
from
07c7ee6 to
0a2a195
Compare
|
@evan-bradley Had some issue with the rebase. Should be fine now |
aishyandapalli
force-pushed
the
span-metrics-oom-fix
branch
from
40fd40f to
1aa302c
Compare
aishyandapalli
force-pushed
the
span-metrics-oom-fix
branch
from
1aa302c to
81c9c59
Compare
albertteoh
approved these changes
Dec 7, 2023
evan-bradley
approved these changes
Dec 12, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix Memory usage for span metrics by limiting the number of exemplars per unique dimensions set/metric key