[pkg/ottl] Add ability to parse conditions #29315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu and
evan-bradley
as code owners
atoulme
reviewed
Nov 17, 2023
atoulme
approved these changes
Nov 17, 2023
TylerHelmuth
force-pushed
the
ottl-condition-parser-add-interfaces
branch
from
061e67a to
325f182
Compare
TylerHelmuth
added
ready to merge
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
**Description:** This PR adds a new public API to support parsing and using conditions. This implementation opted to add ParseConditions directly to the existing Parser instead of creating a second Parser struct. Since any Parser needs the Context, Functions, PathExpressionParser, EnumParser, and telemetry settings the 2 structs would be incredibly similar. See these structs implemented in components here: open-telemetry#29294 **Link to tracking Issue:** <Issue number if applicable> Works towards open-telemetry#13545 **Testing:** <Describe what testing was performed and which tests were added.> Added tests **Documentation:** <Describe the documentation added.> Added godoc strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a new public API to support parsing and using conditions.
This implementation opted to add ParseConditions directly to the existing Parser instead of creating a second Parser struct. Since any Parser needs the Context, Functions, PathExpressionParser, EnumParser, and telemetry settings the 2 structs would be incredibly similar.
See these structs implemented in components here: #29294
Link to tracking Issue:
Works towards #13545
Testing:
Added tests
Documentation:
Added godoc strings