[receiver/pulsarreceiver] - Add encoding extension #29322
Conversation
VihasMakwana
changed the title
github-actions
bot
added
cmd/otelcontribcol
atoulme
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Please rebase |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
VihasMakwana
force-pushed
the
add-encoding-pulsar
branch
4 times, most recently
from
cb1d44d to
cb17c7f
Compare
|
@dmitryax up for review |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
@dmitryax can you review this and reopen it? I can't reopen due to insufficient permissions. |
| @@ -30,7 +30,6 @@ func TestLoadConfig(t *testing.T) { | |||
| Endpoint: "pulsar://localhost:6500", | |||
| ConsumerName: "otel-collector", | |||
| Subscription: "otel-collector", | |||
| Encoding: defaultEncoding, | |||
There was a problem hiding this comment.
What is the default behavior if encoding_extension isn't set? I believe it should be OTLP encoding
There was a problem hiding this comment.
I believe so.
Will change it to OTLP
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Co-authored-by: Dmitrii Anoshin <[email protected]>
|
Not stale. working |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description: This PR introduces the recently added encoding extension to pulsarreceiver.