feat(awsS3Exporter): add support for s3_force_path_style and disable_ssl parameters
#29331
Conversation
|
Please run |
|
I think this looks good as you're just passing info to the aws.Config struct - is there any way to refer to AWS config links for folks in the README? |
davinkevin
force-pushed
the
support-extrat-parameters-to-be-compatible-with-minio
branch
3 times, most recently
from
ff3935f to
9e3d330
Compare
|
👋 @atoulme, I've updated the PR accordingly, thank you for your guidance 😇.
I've made the change in the doc for the If you want I can add a dedicated section about 3rd party s3 implementation, could be useful to those wanting to configure it with Let me know, I can do that in this PR or in a subsequent one, I let you decide 😇 |
davinkevin
force-pushed
the
support-extrat-parameters-to-be-compatible-with-minio
branch
from
9e3d330 to
750d3aa
Compare
|
Subsequent PR sounds good. I think this is good to land as is. |
TylerHelmuth
added
the
ready to merge
…le_ssl` parameters In order to support alternative object-storage, these parameters are useful and help to leverage those systems not compatible with domain style path, or just hosted without ssl (like just deployed in a k8s namespace).
davinkevin
force-pushed
the
support-extrat-parameters-to-be-compatible-with-minio
branch
from
750d3aa to
d6bf72d
Compare
…le_ssl` parameters (open-telemetry#29331) **Description:** In order to support alternative object-storage, these parameters (`s3_force_path_style` and `disable_ssl`) are useful and help to leverage those object storage systems, not compatible with domain style path, or just hosted without ssl (like a minio pod deployed in a k8s namespace). **Testing:**: I've tested it in this project: https://gitlab.com/davinkevin.fr/experimentations/opentelemetry/spring-boot-otel-to-minio It was deployed in a k3d cluster and used to store metrics generated gathered by the prometheus receiver. **Documentation:**, minimal, just description of the two new parameters, usually well known by administrators or operators in charge to connect systems to their S3-Compatible storages.
Description:
In order to support alternative object-storage, these parameters (
s3_force_path_styleanddisable_ssl) are useful and help to leverage those object storage systems, not compatible with domain style path, or just hosted without ssl (like a minio pod deployed in a k8s namespace).Testing::
I've tested it in this project: https://gitlab.com/davinkevin.fr/experimentations/opentelemetry/spring-boot-otel-to-minio
It was deployed in a k3d cluster and used to store metrics generated gathered by the prometheus receiver.
Documentation:, minimal, just description of the two new parameters, usually well known by administrators or operators in charge to connect systems to their S3-Compatible storages.