-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial OAuth #29494
Initial OAuth #29494
Conversation
Please add tests - any chance to reuse the configauth package to set up this oauth client provider? |
No worries. I will add some tests. I did actually use oauth2client from there initially but it threw an error around expecting a map and getting a string whan I passed the oauth2client extenstion in under the auth key? I saw nothing was used in the Sarama config so realised it wasn't supported anyway, so I added this PR. I presume we would need to restructure how things are done to integrate the extension? |
cf620a9
to
d6ad807
Compare
Yeah, for the extension to work we would need to provide a means to wrap the auth provider and then make sarama happy to run it. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Adds OAuth support to Kafka/Sarama
Link to tracking Issue:
Testing:
Documentation:
To use it in the config under exporters: