Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][pkg/stanza] Minor cleanup of fileconsumer setup code #29669

Conversation

djaglowski
Copy link
Member

Follows #29668

@djaglowski djaglowski marked this pull request as ready for review December 6, 2023 03:24
@djaglowski djaglowski requested review from a team and atoulme December 6, 2023 03:24
@djaglowski djaglowski force-pushed the pkg-stanza-fileconsumer-config-cleanup branch from 716bf22 to 5c48e2c Compare December 6, 2023 16:01
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djaglowski djaglowski merged commit 3dfe00f into open-telemetry:main Dec 6, 2023
82 checks passed
@djaglowski djaglowski deleted the pkg-stanza-fileconsumer-config-cleanup branch December 6, 2023 17:02
@github-actions github-actions bot added this to the next release milestone Dec 6, 2023
jayasai470 pushed a commit to jayasai470/opentelemetry-collector-contrib that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants