[cmd/opampsupervisor] Implement Collector bootstrapping #29848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
requested review from
atoulme and
tigrannajaryan
as code owners
tigrannajaryan
approved these changes
Dec 13, 2023
evan-bradley
force-pushed
the
supervisor-bootstrapping
branch
from
3f36c01 to
68a633f
Compare
|
@atoulme This should be in a good spot, could you please take a look? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@atoulme Please take a look whenever you have time. |
atoulme
reviewed
Jan 2, 2024
evan-bradley
force-pushed
the
supervisor-bootstrapping
branch
from
e896ec2 to
f283734
Compare
atoulme
reviewed
Jan 2, 2024
atoulme
approved these changes
Jan 3, 2024
|
LGTM |
|
@evan-bradley can we get this merged? |
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
evan-bradley
force-pushed
the
supervisor-bootstrapping
branch
from
0278280 to
21ee243
Compare
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…ry#29848) **Description:** Utilize the OpAMP extension to get identifying attributes from the Collector. A few things I want to call out: * I moved the Supervisor's various config fragments into separate files that are embedded into the binary. I think this makes them easier to edit. I can also move the changes for the existing fragments to a separate PR if it adds too much to the diff. * I opted to use the OTLP receiver instead of the filelog receiver because it is included in both existing upstream distributions and I expect it is slightly more common. Ideally we should look at other approaches to solve this. **Link to tracking Issue:** Resolves open-telemetry#21071 **Testing:** Added an integration test. --------- Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Evan Bradley <[email protected]>
MovieStoreGuy
pushed a commit
that referenced
this pull request
Apr 9, 2024
**Link to tracking Issue:** <Issue number if applicable> Part of #21043; based on top of #29848 to add test **Testing:** <Describe what testing was performed and which tests were added.> Added integration test --------- Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Utilize the OpAMP extension to get identifying attributes from the Collector.
A few things I want to call out:
Link to tracking Issue:
Resolves #21071
Testing:
Added an integration test.