Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/azuremonitor] reduce public api #30224

Merged
merged 6 commits into from
Mar 14, 2024
Merged

[receiver/azuremonitor] reduce public api #30224

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6068f1
reduce public api [receiver/azuremonitor]
nslaughter Dec 27, 2023
23e53f6
Merge branch 'main' into nslaughter/reduce-public-api-azuremonitorrec…
nslaughter Feb 14, 2024
70bb3cc
add changelog entry
nslaughter Feb 14, 2024
f94b188
Merge branch 'main' into nslaughter/reduce-public-api-azuremonitorrec…
nslaughter Feb 14, 2024
daaeb09
Merge branch 'main' into nslaughter/reduce-public-api-azuremonitorrec…
nslaughter Feb 14, 2024
b864cc2
Merge branch 'main' into nslaughter/reduce-public-api-azuremonitorrec…
nslaughter Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions receiver/azuremonitorreceiver/scraper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ func newScraper(conf *Config, settings receiver.CreateSettings) *azureScraper {
type azureScraper struct {
cred azcore.TokenCredential

clientResources ArmClient
clientMetricsDefinitions MetricsDefinitionsClientInterface
clientMetricsValues MetricsValuesClient
clientResources armClient
clientMetricsDefinitions metricsDefinitionsClientInterface
clientMetricsValues metricsValuesClient

cfg *Config
settings component.TelemetrySettings
Expand All @@ -113,7 +113,7 @@ type azureScraper struct {
mutex *sync.Mutex
}

type ArmClient interface {
type armClient interface {
NewListPager(options *armresources.ClientListOptions) *runtime.Pager[armresources.ClientListResponse]
}

Expand All @@ -134,27 +134,27 @@ func (s *azureScraper) getArmClientOptions() *arm.ClientOptions {
return &options
}

func (s *azureScraper) getArmClient() ArmClient {
func (s *azureScraper) getArmClient() armClient {
nslaughter marked this conversation as resolved.
Show resolved Hide resolved
client, _ := s.armClientFunc(s.cfg.SubscriptionID, s.cred, s.armClientOptions)
return client
}

type MetricsDefinitionsClientInterface interface {
type metricsDefinitionsClientInterface interface {
NewListPager(resourceURI string, options *armmonitor.MetricDefinitionsClientListOptions) *runtime.Pager[armmonitor.MetricDefinitionsClientListResponse]
}

func (s *azureScraper) getMetricsDefinitionsClient() MetricsDefinitionsClientInterface {
func (s *azureScraper) getMetricsDefinitionsClient() metricsDefinitionsClientInterface {
client, _ := s.armMonitorDefinitionsClientFunc(s.cfg.SubscriptionID, s.cred, s.armClientOptions)
return client
}

type MetricsValuesClient interface {
type metricsValuesClient interface {
List(ctx context.Context, resourceURI string, options *armmonitor.MetricsClientListOptions) (
armmonitor.MetricsClientListResponse, error,
)
}

func (s *azureScraper) GetMetricsValuesClient() MetricsValuesClient {
func (s *azureScraper) GetMetricsValuesClient() metricsValuesClient {
client, _ := s.armMonitorMetricsClientFunc(s.cfg.SubscriptionID, s.cred, s.armClientOptions)
return client
}
Expand Down
Loading