-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] Updated docs for Time converter #32185
[pkg/ottl] Updated docs for Time converter #32185
Conversation
…tor-contrib into ottl/time-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just formatting nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this under the Time
section header:
`Time(target, format`
and then change the reference from time
to target
.
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
…tor-contrib into ottl/time-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more nits, but it looks great! Thanks for your patience and for making all of these updates, I really appreciate it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me outside the open items. Thanks @crobert-1 for giving this a thorough review.
Co-authored-by: Curtis Robert <[email protected]>
Description:
Updated docs for ottl converter so it includes more information about substitutes users can use
Few examples with timezone handling were added
Link to tracking Issue: #32140
Testing: no testing
Documentation: