[processor/resourcedetection] Fetch CPU info only if required #33774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal/metadataproviders
processor/resourcedetection
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
call_cpu_info_only_on_demand
branch
from
5634b88 to
7b6139b
Compare
mx-psi
reviewed
Jun 26, 2024
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
call_cpu_info_only_on_demand
branch
from
c20a2b6 to
68ede4b
Compare
This was
linked to
issues
Jun 26, 2024
Closed
mx-psi
approved these changes
Jun 26, 2024
|
@cwegener will wait until end of week to merge this in case you want to leave a review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR changes the system resource detector so as to only try to fetch the CPU info when required. The CPU info attributes are disabled by default so we should only fetch this information when at least one of those is enabled.
Link to tracking Issue: #33768
Testing: Added unti-tests
Documentation: ~
/cc @mx-psi