[pkg/ottl]: Add MD5 function #33793
Merged
[pkg/ottl]: Add MD5 function #33793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
evan-bradley
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
We'll want to update the hash function alternative recommendation, but otherwise this looks good to me. Thanks @edmocosta.
atoulme
approved these changes
Aug 1, 2024
Co-authored-by: Evan Bradley <[email protected]>
Thanks for reviewing folks! I've applied @evan-bradley suggestion to update the alternative recommended hash function. |
|
@TylerHelmuth please take a look when you are able. |
MovieStoreGuy
approved these changes
Aug 9, 2024
|
@TylerHelmuth Please take a look if you have time today, it would be nice to get this in for the next release. |
TylerHelmuth
approved these changes
Aug 9, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Introduced the `MD5` converter function which returns the MD5 hash/digest of the given `value` (path expression to a string telemetry field or a literal string). **Link to tracking Issue:** open-telemetry#33792 **Testing:** <Describe what testing was performed and which tests were added.> - Unit tests - E2E tests **Documentation:** A new README entry was added for the `MD5` function. --------- Co-authored-by: Evan Bradley <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduced the
MD5converter function which returns the MD5 hash/digest of the givenvalue(path expression to a string telemetry field or a literal string).Link to tracking Issue: #33792
Testing:
Documentation:
A new README entry was added for the
MD5function.