[receiver/sqlqueryreceiver] Fix tracking results by timestamp column #35195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
reviewed
Sep 16, 2024
crobert-1
approved these changes
Sep 18, 2024
@crobert-1 |
crobert-1
added
the
ready to merge
andrzej-stencel
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Thank you for this fix @Grandys.
I'm only worried that we don't have test coverage for logs tracking for database engines other than PostgreSQL. This means that we're treading in the dark with this feature and changes to it like this valuable fix. As a result, there's a risk that this fix breaks the logs tracking feature for one of the untested engines (e.g. because the RFC3939Nano format is not supported).
I'm supportive of merging this fix, given that the logs stability is currently development. We should have integrations tests for all supported database engines before we move logs support out of development into alpha stability or further.
andrzej-stencel
merged commit 4c6d6a5
into
open-telemetry:main
162 of 163 checks passed
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…pen-telemetry#35195) **Description:** Formats retrieved time columns with milliseconds precision, so they are not reprocessed when used as a tracking_column **Link to tracking Issue:** open-telemetry#35194 **Testing:** Added integration test, updated test data **Documentation:** n/a Closes open-telemetry#35194
songy23
pushed a commit
that referenced
this pull request
Jan 29, 2025
…36922) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Mainly added test for sqlserver, plus added coverage for logs (as requested in [comment](#35195 (review))) <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #29695 <!--Describe what testing was performed and which tests were added.--> #### Testing Main changes: * Added metrics tests for SqlServer * Covered MySql, SqlServer and Oracle for logs Improvements: - To avoid repetitions, changed approach to "parameterized" tests - run the same test flow for different database engines (for logs only). - Do not hardcode "localhost" and host port, get these values from testcontainers. - Replaced inserting test values into the database from running CLI commands in the container to executing SQL commands. - Updated Oracle init script to use `otel` schema instead of `sys`. Important: For Oracle and SQL Server, tests are **skipped** (tested locally) - I expect them to fail due to #27577 (which was not fixed but closed due to inactivity). <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.-->
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…pen-telemetry#36922) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Mainly added test for sqlserver, plus added coverage for logs (as requested in [comment](open-telemetry#35195 (review))) <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#29695 <!--Describe what testing was performed and which tests were added.--> #### Testing Main changes: * Added metrics tests for SqlServer * Covered MySql, SqlServer and Oracle for logs Improvements: - To avoid repetitions, changed approach to "parameterized" tests - run the same test flow for different database engines (for logs only). - Do not hardcode "localhost" and host port, get these values from testcontainers. - Replaced inserting test values into the database from running CLI commands in the container to executing SQL commands. - Updated Oracle init script to use `otel` schema instead of `sys`. Important: For Oracle and SQL Server, tests are **skipped** (tested locally) - I expect them to fail due to open-telemetry#27577 (which was not fixed but closed due to inactivity). <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Formats retrieved time columns with milliseconds precision, so they are not reprocessed when used as a tracking_column
Link to tracking Issue: #35194
Testing: Added integration test, updated test data
Documentation: n/a
Closes #35194