[chore]: enable useless-assert rule from testifylint #35219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
testifylint/useless-assert
branch
from
cebbbe9 to
ca74d7d
Compare
codeboten
approved these changes
Sep 16, 2024
mmorel-35
force-pushed
the
testifylint/useless-assert
branch
from
ca74d7d to
6890a5f
Compare
mmorel-35
force-pushed
the
testifylint/useless-assert
branch
2 times, most recently
from
f04926e to
25acd5f
Compare
|
@codeboten ,
|
mmorel-35
force-pushed
the
testifylint/useless-assert
branch
2 times, most recently
from
3175542 to
9000ed3
Compare
mmorel-35
force-pushed
the
testifylint/useless-assert
branch
2 times, most recently
from
c7133d6 to
166d473
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testifylint/useless-assert
branch
from
166d473 to
436cc58
Compare
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…35219) #### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [useless-assert](https://github.com/Antonboom/testifylint?tab=readme-ov-file#useless-assert) rule from [testifylint](https://github.com/Antonboom/testifylint) Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables useless-assert rule from testifylint