Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Schema Processor Revamp [Part 2] - ChangeList and Revision #35267

Conversation

ankitpatel96
Copy link
Contributor

@ankitpatel96 ankitpatel96 commented Sep 17, 2024

Description:
This is a slice of changes from #35248

This PR details how operators are used to build the execution pipeline for a given schemafile.

Changed files from the previous PR are:

processor/schemaprocessor/internal/changelist/changelist.go
processor/schemaprocessor/internal/translation/revision_v1.go
processor/schemaprocessor/internal/translation/revision_v1_test.go
processor/schemaprocessor/go.mod

I'm asking a maintainer if they would be willing to push a copy of the previous PR's branch to the core repo so I can switch the base of this PR to the previous PR - thus only the stacked changes would be shown.

Edit: this is apparently not easily supported - so asking reviewers to just focus on the changed files listed above. Sorry about that!

Testing:
Unit tests

@github-actions github-actions bot added the processor/schema Schema processor label Sep 17, 2024
@ankitpatel96 ankitpatel96 force-pushed the ankit-schema-processor-changelist-revision branch 2 times, most recently from 62ff9a6 to ced8125 Compare October 1, 2024 22:03
@ankitpatel96 ankitpatel96 force-pushed the ankit-schema-processor-changelist-revision branch 2 times, most recently from 8c2f952 to 9589ec9 Compare October 16, 2024 22:01
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 31, 2024
@ankitpatel96 ankitpatel96 force-pushed the ankit-schema-processor-changelist-revision branch 2 times, most recently from 891d2d3 to e198232 Compare November 7, 2024 22:32
@ankitpatel96 ankitpatel96 marked this pull request as ready for review November 7, 2024 22:42
@ankitpatel96 ankitpatel96 requested a review from a team as a code owner November 7, 2024 22:42
@github-actions github-actions bot removed the Stale label Nov 8, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 23, 2024
@github-actions github-actions bot removed the Stale label Nov 28, 2024
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankitpatel96

@ankitpatel96 ankitpatel96 force-pushed the ankit-schema-processor-changelist-revision branch from cd18775 to 0f2a55c Compare December 2, 2024 21:58
@ankitpatel96 ankitpatel96 changed the title Schema Processor Revamp [Part 2] - ChangeList and Revision [chore] Schema Processor Revamp [Part 2] - ChangeList and Revision Dec 3, 2024
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 3, 2024
@mx-psi mx-psi merged commit 9ae6a48 into open-telemetry:main Dec 3, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 3, 2024
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this pull request Dec 5, 2024
…pen-telemetry#35267)

**Description:** <Describe what has changed.>
This is a slice of changes from
open-telemetry#35248

This PR details how operators are used to build the execution pipeline
for a given schemafile.



Changed files from the [previous
PR](open-telemetry#35214)
are:

processor/schemaprocessor/internal/changelist/changelist.go
processor/schemaprocessor/internal/translation/revision_v1.go
processor/schemaprocessor/internal/translation/revision_v1_test.go
processor/schemaprocessor/go.mod

I'm asking a maintainer if they would be willing to push a copy of the
previous PR's branch to the core repo so I can switch the base of this
PR to the previous PR - thus only the stacked changes would be shown.

Edit: this is apparently not easily supported - so asking reviewers to
just focus on the changed files listed above. Sorry about that!

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit tests

---------

Co-authored-by: Pablo Baeyens <[email protected]>
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
…pen-telemetry#35267)

**Description:** <Describe what has changed.>
This is a slice of changes from
open-telemetry#35248

This PR details how operators are used to build the execution pipeline
for a given schemafile.



Changed files from the [previous
PR](open-telemetry#35214)
are:

processor/schemaprocessor/internal/changelist/changelist.go
processor/schemaprocessor/internal/translation/revision_v1.go
processor/schemaprocessor/internal/translation/revision_v1_test.go
processor/schemaprocessor/go.mod

I'm asking a maintainer if they would be willing to push a copy of the
previous PR's branch to the core repo so I can switch the base of this
PR to the previous PR - thus only the stacked changes would be shown.

Edit: this is apparently not easily supported - so asking reviewers to
just focus on the changed files listed above. Sorry about that!

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit tests

---------

Co-authored-by: Pablo Baeyens <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…pen-telemetry#35267)

**Description:** <Describe what has changed.>
This is a slice of changes from
open-telemetry#35248

This PR details how operators are used to build the execution pipeline
for a given schemafile.



Changed files from the [previous
PR](open-telemetry#35214)
are:

processor/schemaprocessor/internal/changelist/changelist.go
processor/schemaprocessor/internal/translation/revision_v1.go
processor/schemaprocessor/internal/translation/revision_v1_test.go
processor/schemaprocessor/go.mod

I'm asking a maintainer if they would be willing to push a copy of the
previous PR's branch to the core repo so I can switch the base of this
PR to the previous PR - thus only the stacked changes would be shown.

Edit: this is apparently not easily supported - so asking reviewers to
just focus on the changed files listed above. Sorry about that!

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit tests

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/schema Schema processor Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants