windowsservicereceiver wireframe #35362
Conversation
shalper2
force-pushed
the
31377-windowsservicereceiver-wireframe
branch
from
bcf5660 to
6055531
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I'll be reviewing this PR. |
shalper2
force-pushed
the
31377-windowsservicereceiver-wireframe
branch
2 times, most recently
from
5b0fb01 to
c179923
Compare
| scraperhelper.ControllerConfig `mapstructure:",squash"` | ||
| Services []string `mapstructure:"services"` // user provided list of services to monitor with receiver | ||
| MonitorAll bool `mapstructure:"monitor_all"` // monitor all services on host machine. supercedes services | ||
| } |
There was a problem hiding this comment.
Assuming the default values for Services and MonitorAll it is not clear what would be the result: all services or none? It seems none giving that the boolean is false and the list of services is empty. Let me look at the rest of the code before making a suggestion here.
There was a problem hiding this comment.
Looking at the previous art from telegraf: it seems reasonable to have a include and a exclude list of services. If the include is empty it assumes all services minus the exclude list.
shalper2
force-pushed
the
31377-windowsservicereceiver-wireframe
branch
from
c179923 to
731526c
Compare
shalper2
force-pushed
the
31377-windowsservicereceiver-wireframe
branch
3 times, most recently
from
6358dd5 to
0566f19
Compare
| } | ||
|
|
||
| func (m *Manager) Disconnect() error { | ||
| return windows.CloseServiceHandle(m.Handle) |
There was a problem hiding this comment.
What happens if the Handle has the default value? Does it return an error?
There was a problem hiding this comment.
It absolutely can return an error. obviously should be handled by the caller
| } | ||
|
|
||
| func GetService(sname string) (*ServiceStatus, error) { | ||
| m, err := SCConnect() |
There was a problem hiding this comment.
We should connect at Start instead of on every call to GetService.
|
|
||
| func GetService(sname string) (*ServiceStatus, error) { | ||
| m, err := SCConnect() | ||
| defer m.Disconnect() |
There was a problem hiding this comment.
Typically you should add this defer only if connect succeeded.
| func (s *ServiceStatus) getStatus() error { | ||
| st, err := s.service.Query() | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
This is not a problem with the current code since the handle to the service is opened every time a GetService call is made. However, it is good to pay attention here that the value of s.ServiceStatus in case of error will be the default value for the type (0 in this case).
There was a problem hiding this comment.
Similar in the call to Config below.
| description: Gauge value containing service status as an integer value. | ||
| extended_documentation: > | ||
| Gauge values map to service status as follows: | ||
| 1 - Stopped, |
There was a problem hiding this comment.
| 1 - Stopped, | |
| 0 - Failed to retrieve service status, | |
| 1 - Stopped, |
shalper2
force-pushed
the
31377-windowsservicereceiver-wireframe
branch
3 times, most recently
from
a9bf88e to
7bc070a
Compare
shalper2
force-pushed
the
31377-windowsservicereceiver-wireframe
branch
from
7bc070a to
7a65265
Compare
shalper2
force-pushed
the
31377-windowsservicereceiver-wireframe
branch
from
7a65265 to
26077db
Compare
Description: wireframe and early pass at api for a windowsservices receiver as requested in issue 31377
Link to tracking Issue: 31377
Testing: none yet
Documentation: documentation around receiver scope in README.md