feat: receiver/prometheusremotewrite - Implement body unmarshaling #35624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
force-pushed
the
prwreceiver-bodyunmarshal
branch
3 times, most recently
from
df1caad to
cd0941f
Compare
|
If everything looks good, one strategy is to merge this PR instead of the other two. This way we get all commits in without needing to rebase several PRs. |
ArthurSens
force-pushed
the
prwreceiver-bodyunmarshal
branch
from
cd0941f to
ac68ba0
Compare
ArthurSens
force-pushed
the
prwreceiver-bodyunmarshal
branch
from
ac68ba0 to
4d64d78
Compare
dashpole
reviewed
Oct 9, 2024
ArthurSens
force-pushed
the
prwreceiver-bodyunmarshal
branch
2 times, most recently
from
890e8e6 to
64def58
Compare
dashpole
approved these changes
Oct 18, 2024
|
looks like this needs some go mod updates. The diff currently downgrades otel dependences |
ArthurSens
force-pushed
the
prwreceiver-bodyunmarshal
branch
from
d4346dc to
48cd5d6
Compare
|
PR rebased! |
dashpole
added
ready to merge
|
Signed-off-by: Arthur Silva Sens <[email protected]>
ArthurSens
force-pushed
the
prwreceiver-bodyunmarshal
branch
from
48cd5d6 to
8d9219e
Compare
|
Fixed :) |
dashpole
added
the
ready to merge
ArthurSens
added a commit
to ArthurSens/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
…pen-telemetry#35624) This PR builds on top of open-telemetry#35535 and open-telemetry#35565. We're now making sure we're able to unmarshal a remote write request, while also exercising the decompression that is made by OTel's confighttp. Signed-off-by: Arthur Silva Sens <[email protected]>
MovieStoreGuy
pushed a commit
that referenced
this pull request
Dec 15, 2024
#### Description This PR builds on top of #35535, #35565 and #35624. Here we're parsing labels into resource/metric attributes. It's still not great because resource attributes (with exception to `service.namespace`, `service.name` and `service.name.id`) are encoded into a special metric called `target_info`. Metrics related to specific target infos may arrive in separate write requests, so it may be impossible to build the full OTLP metric in a stateless way. In this PR I'm ignoring this problem 😛, and transforming `job` and `instance` labels into resource attributes, while all other labels become scope attributes. Please focus on the latest commit when reviewing this PR :) 1c9ff80 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…pen-telemetry#35624) #### Description This PR builds on top of open-telemetry#35535 and open-telemetry#35565. We're now making sure we're able to unmarshal a remote write request, while also exercising the decompression that is made by OTel's confighttp. Signed-off-by: Arthur Silva Sens <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description This PR builds on top of open-telemetry#35535, open-telemetry#35565 and open-telemetry#35624. Here we're parsing labels into resource/metric attributes. It's still not great because resource attributes (with exception to `service.namespace`, `service.name` and `service.name.id`) are encoded into a special metric called `target_info`. Metrics related to specific target infos may arrive in separate write requests, so it may be impossible to build the full OTLP metric in a stateless way. In this PR I'm ignoring this problem 😛, and transforming `job` and `instance` labels into resource attributes, while all other labels become scope attributes. Please focus on the latest commit when reviewing this PR :) 1c9ff80 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
#### Description This PR builds on top of open-telemetry#35535, open-telemetry#35565 and open-telemetry#35624. Here we're parsing labels into resource/metric attributes. It's still not great because resource attributes (with exception to `service.namespace`, `service.name` and `service.name.id`) are encoded into a special metric called `target_info`. Metrics related to specific target infos may arrive in separate write requests, so it may be impossible to build the full OTLP metric in a stateless way. In this PR I'm ignoring this problem 😛, and transforming `job` and `instance` labels into resource attributes, while all other labels become scope attributes. Please focus on the latest commit when reviewing this PR :) 1c9ff80 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on top of #35535 and #35565. We're now making sure we're able to unmarshal a remote write request, while also exercising the decompression that is made by OTel's confighttp.