Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Add parser utility to rewrite statements appending missing paths context #35716

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions pkg/ottl/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import (
"context"
"errors"
"fmt"
"sort"
"strings"

"github.com/alecthomas/participle/v2"
"go.opentelemetry.io/collector/component"
Expand Down Expand Up @@ -195,6 +197,33 @@ func (p *Parser[K]) ParseCondition(condition string) (*Condition[K], error) {
}, nil
}

// prependContextToStatementPaths changes the given OTTL statement adding the context name prefix
// to all context-less paths. No modifications are performed for paths which [Path.Context]
// value matches any WithPathContextNames value.
// The context argument must be valid WithPathContextNames value, otherwise an error is returned.
func (p *Parser[K]) prependContextToStatementPaths(context string, statement string) (string, error) {
if _, ok := p.pathContextNames[context]; !ok {
return statement, fmt.Errorf(`unknown context "%s" for parser %T, valid options are: %s`, context, p, p.buildPathContextNamesText(""))
}
parsed, err := parseStatement(statement)
if err != nil {
return "", err
}
paths := getParsedStatementPaths(parsed)
if len(paths) == 0 {
return statement, nil
}

var missingContextOffsets []int
for _, it := range paths {
if _, ok := p.pathContextNames[it.Context]; !ok {
missingContextOffsets = append(missingContextOffsets, it.Pos.Offset)
}
}

return insertContextIntoStatementOffsets(context, statement, missingContextOffsets)
}

var parser = newParser[parsedStatement]()
var conditionParser = newParser[booleanExpression]()

Expand Down Expand Up @@ -226,6 +255,30 @@ func parseCondition(raw string) (*booleanExpression, error) {
return parsed, nil
}

func insertContextIntoStatementOffsets(context string, statement string, offsets []int) (string, error) {
if len(offsets) == 0 {
return statement, nil
}

contextPrefix := context + "."
var sb strings.Builder
sb.Grow(len(statement) + (len(contextPrefix) * len(offsets)))

sort.Ints(offsets)
left := 0
for _, offset := range offsets {
if offset < 0 || offset > len(statement) {
return statement, fmt.Errorf(`failed to insert context "%s" into statement "%s": offset %d is out of range`, context, statement, offset)
}
sb.WriteString(statement[left:offset])
sb.WriteString(contextPrefix)
left = offset
}
sb.WriteString(statement[left:])

return sb.String(), nil
}

// newParser returns a parser that can be used to read a string into a parsedStatement. An error will be returned if the string
// is not formatted for the DSL.
func newParser[G any]() *participle.Parser[G] {
Expand Down
137 changes: 137 additions & 0 deletions pkg/ottl/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2714,3 +2714,140 @@ func Test_ConditionSequence_Eval_Error(t *testing.T) {
})
}
}

func Test_prependContextToStatementPaths_InvalidStatement(t *testing.T) {
ps, err := NewParser(
CreateFactoryMap[any](),
testParsePath[any],
componenttest.NewNopTelemetrySettings(),
WithEnumParser[any](testParseEnum),
WithPathContextNames[any]([]string{"foo", "bar"}),
)
require.NoError(t, err)
_, err = ps.prependContextToStatementPaths("foo", "this is invalid")
require.ErrorContains(t, err, `statement has invalid syntax`)
}

func Test_prependContextToStatementPaths_InvalidContext(t *testing.T) {
ps, err := NewParser(
CreateFactoryMap[any](),
testParsePath[any],
componenttest.NewNopTelemetrySettings(),
WithEnumParser[any](testParseEnum),
WithPathContextNames[any]([]string{"foo", "bar"}),
)
require.NoError(t, err)
_, err = ps.prependContextToStatementPaths("foobar", "set(foo, 1)")
require.ErrorContains(t, err, `unknown context "foobar" for parser`)
}

func Test_prependContextToStatementPaths_Success(t *testing.T) {
type mockSetArguments[K any] struct {
Target Setter[K]
Value Getter[K]
}

mockSetFactory := NewFactory("set", &mockSetArguments[any]{}, func(_ FunctionContext, _ Arguments) (ExprFunc[any], error) {
return func(_ context.Context, _ any) (any, error) {
return nil, nil
}, nil
})

tests := []struct {
name string
statement string
context string
pathContextNames []string
expected string
}{
{
name: "no paths",
statement: `set("foo", 1)`,
context: "bar",
pathContextNames: []string{"bar"},
expected: `set("foo", 1)`,
},
{
name: "single path with context",
statement: `set(span.value, 1)`,
context: "span",
pathContextNames: []string{"span"},
expected: `set(span.value, 1)`,
},
{
name: "single path without context",
statement: "set(value, 1)",
context: "span",
pathContextNames: []string{"span"},
expected: "set(span.value, 1)",
},
{
name: "single path with context - multiple context names",
statement: "set(span.value, 1)",
context: "spanevent",
pathContextNames: []string{"spanevent", "span"},
expected: "set(span.value, 1)",
},
{
name: "multiple paths with the same context",
statement: `set(span.value, 1) where span.attributes["foo"] == "foo" and span.id == 1`,
context: "another",
pathContextNames: []string{"another", "span"},
expected: `set(span.value, 1) where span.attributes["foo"] == "foo" and span.id == 1`,
},
{
name: "multiple paths with different contexts",
statement: `set(another.value, 1) where span.attributes["foo"] == "foo" and another.id == 1`,
context: "another",
pathContextNames: []string{"another", "span"},
expected: `set(another.value, 1) where span.attributes["foo"] == "foo" and another.id == 1`,
},
{
name: "multiple paths with and without contexts",
statement: `set(value, 1) where span.attributes["foo"] == "foo" and id == 1`,
context: "spanevent",
pathContextNames: []string{"spanevent", "span"},
expected: `set(spanevent.value, 1) where span.attributes["foo"] == "foo" and spanevent.id == 1`,
},
{
name: "multiple paths without context",
statement: `set(value, 1) where name == attributes["foo.name"]`,
context: "span",
pathContextNames: []string{"span"},
expected: `set(span.value, 1) where span.name == span.attributes["foo.name"]`,
},
{
name: "function path parameter without context",
statement: `set(attributes["test"], "pass") where IsMatch(name, "operation[AC]")`,
context: "log",
pathContextNames: []string{"log"},
expected: `set(log.attributes["test"], "pass") where IsMatch(log.name, "operation[AC]")`,
},
{
name: "function path parameter with context",
statement: `set(attributes["test"], "pass") where IsMatch(resource.name, "operation[AC]")`,
context: "log",
pathContextNames: []string{"log", "resource"},
expected: `set(log.attributes["test"], "pass") where IsMatch(resource.name, "operation[AC]")`,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ps, err := NewParser(
CreateFactoryMap[any](mockSetFactory),
testParsePath[any],
componenttest.NewNopTelemetrySettings(),
WithEnumParser[any](testParseEnum),
WithPathContextNames[any](tt.pathContextNames),
)

require.NoError(t, err)
require.NotNil(t, ps)

result, err := ps.prependContextToStatementPaths(tt.context, tt.statement)
require.NoError(t, err)
assert.Equal(t, tt.expected, result)
})
}
}
Loading