Add useragent to awsemfexporter #35748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
add-awsemflogexporter-user-agent
branch
2 times, most recently
from
681e09f to
03723d0
Compare
harrryr
force-pushed
the
add-awsemflogexporter-user-agent
branch
from
03723d0 to
fc991c8
Compare
wangzlei
approved these changes
Oct 11, 2024
harrryr
force-pushed
the
add-awsemflogexporter-user-agent
branch
from
6acab1b to
d3c54f0
Compare
Aneurysm9
suggested changes
Oct 14, 2024
There was a problem hiding this comment.
I continue to have the same concerns I previously expressed regarding use of the user agent header to exfiltrate information about the workload being processed.
jj22ee
reviewed
Oct 15, 2024
| language = truncate(language, attrLengthLimit) | ||
| version = truncate(version, attrLengthLimit) | ||
| value := ua.cache.Get(language) | ||
| valueMap := make(map[string]struct{}) |
There was a problem hiding this comment.
The name valueMap may be a bit confusing, given that we are using this value to store a set of versions.
Can we update the variable name (e.g. versionSet) and add comment that we are treating the map as a set?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picking from downstream: amazon-contributing#170
Changes include:
Some additional changes were included:
Testing:
Added unit test