Fix todo issue in googlecloudmonitoringreceiver #35760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek-at-cloudwerx
requested review from
dashpole,
TylerHelmuth and
a team
as code owners
abhishek-at-cloudwerx
changed the title
dashpole
reviewed
Oct 13, 2024
| @@ -314,8 +314,6 @@ func (mr *monitoringReceiver) convertGCPTimeSeriesToMetrics(metrics pmetric.Metr | |||
| mr.metricsBuilder.ConvertSumToMetrics(timeSeries, m) | |||
| case metric.MetricDescriptor_DELTA: | |||
| mr.metricsBuilder.ConvertDeltaToMetrics(timeSeries, m) | |||
| // TODO: Add support for HISTOGRAM | |||
There was a problem hiding this comment.
I'm not sure why we are removing these. We should keep them around until it is implemented.
There was a problem hiding this comment.
Yes, that's correct.
I'll close the PR for now as it's important to implement this in the future.
atoulme
requested changes
Oct 16, 2024
|
Support for histograms will be needed in the future, so the TODO will remain as is. |
abhishek-at-cloudwerx
deleted the
remove-todo-googlecloudmonitoringreceiver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix todo comments issue in googlecloudmonitoringreceiver receiver component
Link to tracking issue
Testing
Documentation