[chore] remove obsolete note about auth type limitations in k8sclusterreceiver
#35853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
povilasv
approved these changes
Oct 18, 2024
TylerHelmuth
approved these changes
Oct 28, 2024
jpbarto
pushed a commit
to jpbarto/opentelemetry-collector-contrib
that referenced
this pull request
Oct 29, 2024
…erreceiver` (open-telemetry#35853) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR removes the note about `serviceAccount` being the only auth type being supported by the `k8sclusterreceiver`, since in the meantime support for `kubeConfig` auth type has been added (also verified this manually to be safe) <!--Describe the documentation added.--> #### Documentation Updated the readme of the `k8sclusterreceiver` <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Florian Bacher <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…erreceiver` (open-telemetry#35853) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR removes the note about `serviceAccount` being the only auth type being supported by the `k8sclusterreceiver`, since in the meantime support for `kubeConfig` auth type has been added (also verified this manually to be safe) <!--Describe the documentation added.--> #### Documentation Updated the readme of the `k8sclusterreceiver` <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Florian Bacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the note about
serviceAccountbeing the only auth type being supported by thek8sclusterreceiver, since in the meantime support forkubeConfigauth type has been added (also verified this manually to be safe)Documentation
Updated the readme of the
k8sclusterreceiver