docs(clickhouseexporter): add examples of missing DDL tables #35903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpencerTorres
approved these changes
Oct 22, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
hanjm
approved these changes
Nov 15, 2024
|
This is a non-code change and an easy merge, can we get someone to approve? Thanks! |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
not stale, ready to merge |
atoulme
approved these changes
Jan 17, 2025
atoulme
added
ready to merge
|
Please fix CI: |
atoulme
reviewed
Jan 17, 2025
atoulme
added
the
ready to merge
songy23
reviewed
Jan 24, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…lemetry#35903) #### Description Add Missing Examples Of DDL For Clickhouse Exporter #### Testing N/A #### Documentation Added two files with the example DDL of two tables: `otel_metrics_exponential_histogram` and `otel_metrics_gauge`. These were not in the examples but they are indeed created by the exporter. This was confusing as we do manage our own schema. The docs had incomplete examples. See https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/clickhouseexporter#schema-management --------- Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Missing Examples Of DDL For Clickhouse Exporter
Testing
N/A
Documentation
Added two files with the example DDL of two tables:
otel_metrics_exponential_histogramand
otel_metrics_gauge.These were not in the examples but they are indeed created by the exporter. This was
confusing as we do manage our own schema. The docs had incomplete examples. See https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/clickhouseexporter#schema-management