Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(clickhouseexporter): add examples of missing DDL tables #35903

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ElderMael
Copy link

@ElderMael ElderMael commented Oct 21, 2024

Description

Add Missing Examples Of DDL For Clickhouse Exporter

Testing

N/A

Documentation

Added two files with the example DDL of two tables: otel_metrics_exponential_histogram
and otel_metrics_gauge.

These were not in the examples but they are indeed created by the exporter. This was
confusing as we do manage our own schema. The docs had incomplete examples. See https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/clickhouseexporter#schema-management

Copy link
Member

@SpencerTorres SpencerTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these 👍

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 11, 2024
@github-actions github-actions bot removed the Stale label Nov 15, 2024
@SpencerTorres
Copy link
Member

This is a non-code change and an easy merge, can we get someone to approve? Thanks!

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 12, 2024
@github-actions github-actions bot removed the Stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants