Create a skeleton for the 'blobuploadprocessor'. #35966
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the initial mailing.
|
Ack. My availability is limited until after kubecon, but I will try to get to this when I can. |
dashpole
reviewed
Oct 31, 2024
dashpole
reviewed
Oct 31, 2024
dashpole
reviewed
Oct 31, 2024
michaelsafyan
changed the title
dashpole
reviewed
Nov 14, 2024
| note: Processor for uploading pieces of a signal to blob storage and replacing with a ref | ||
| issues: [33737] | ||
| subtext: Skeleton implementation at the moment. | ||
| change_logs: [] |
There was a problem hiding this comment.
Suggested change
| change_logs: [] | |
| change_logs: [api, user] |
| @@ -20,6 +20,7 @@ body: | |||
| - confmap/provider/aesprovider | |||
| - confmap/provider/s3provider | |||
| - confmap/provider/secretsmanagerprovider | |||
| - connector/blobupload | |||
| @@ -20,6 +20,7 @@ body: | |||
| - confmap/provider/aesprovider | |||
| - confmap/provider/s3provider | |||
| - confmap/provider/secretsmanagerprovider | |||
| - connector/blobupload | |||
| @@ -25,6 +25,7 @@ body: | |||
| - confmap/provider/aesprovider | |||
| - confmap/provider/s3provider | |||
| - confmap/provider/secretsmanagerprovider | |||
| - connector/blobupload | |||
| @@ -0,0 +1,96 @@ | |||
| # Blob Upload Connector | |||
There was a problem hiding this comment.
Suggested change
| # Blob Upload Connector | |
| # Blob Upload Processor |
| "github.com/open-telemetry/opentelemetry-collector-contrib/processor/blobuploadprocessor/internal/metadata" | ||
| ) | ||
|
|
||
| // NewFactoryWithDeps instantiates the factory with dependency injection, allowing |
There was a problem hiding this comment.
Suggested change
| // NewFactoryWithDeps instantiates the factory with dependency injection, allowing | |
| // newFactoryWithDeps instantiates the factory with dependency injection, allowing |
| # Implementation still in-progress. Please follow along at: | ||
| # https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/33737 | ||
| development: [traces, logs] | ||
| distributions: [contrib] |
There was a problem hiding this comment.
adding this to contrib is done after the implementation is complete (it reaches alpha).
Suggested change
| distributions: [contrib] | |
| distributions: [] |
| skip: false | ||
| ignore: | ||
| # See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
| top: go.opencensus.io/stats/view.(*worker).start |
There was a problem hiding this comment.
Strange that this is required given opencensus isn't in the go.sum. We can try removing it in a follow-up.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a skeleton for the
blobuploadprocessorcomponent.A more fleshed out implementation exists in:
blobuploadconnector- span + span events implementationblobuploadconnector_logs- start of implementation for logs, branching from the span + span events oneHowever, the size of the entire thing is a bit unwieldy and likely to become a barrier for an effective code review.
In order to make progress upstreaming this and to ensure a reasonable implementation path, I'm now trying to break out little bits of the implementation into separate, smaller, more focused PRs. And, in the process of this, attempting to simplify the code, improve testing, etc. over the reference proof-of-concept.
Link to tracking issue
#33737 : "New component: Blob Upload Processor"
Testing
Contains a "smoke test" in
package_test.gothat validates the basic contract for the connector and ensures non-crashing.Also contains a few other unit tests and placeholders for additional unit tests.
As actual implementation pieces land in subsequent PRs, we will add additional corresponding tests.
Documentation
Contains a
README.mdthat explains the purpose of this component and its intended trajectory.Also contains a
metadata.yamlproviding structured documentation for the component.We will update the
README.mddocument as additional implementation lands to keep it up-to-date with actual state.