Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][pkg/stanza] refactor: remove function juggling #36108

Merged

Conversation

andrzej-stencel
Copy link
Member

Separates header processing functions from content processing functions to improve code clarity.
This is a follow-up from #35870 (comment).

Separates header processing functions from content processing functions to improve code clarity.
This is a follow-up from open-telemetry#35870 (comment).
@@ -74,7 +74,6 @@ func (f *Factory) NewReaderFromMetadata(file *os.File, m *Metadata) (r *Reader,
initialBufferSize: f.InitialBufferSize,
maxLogSize: f.MaxLogSize,
decoder: decode.New(f.Encoding),
lineSplitFunc: f.SplitFunc,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this line, as lineSplitFunc is being reassigned below in line 106.

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks @andrzej-stencel

@djaglowski djaglowski merged commit 568cbb6 into open-telemetry:main Oct 31, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 31, 2024
ArthurSens pushed a commit to ArthurSens/opentelemetry-collector-contrib that referenced this pull request Nov 4, 2024
…y#36108)

Separates header processing functions from content processing functions
to improve code clarity.
This is a follow-up from
open-telemetry#35870 (comment).
@andrzej-stencel andrzej-stencel deleted the remove-function-juggling branch November 5, 2024 10:53
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…y#36108)

Separates header processing functions from content processing functions
to improve code clarity.
This is a follow-up from
open-telemetry#35870 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants