Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awsfirehosereceiver] Add otlp_v1 into the unmarshalers map #36125

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

kaiyan-sheng
Copy link
Contributor

Description

After able to test E2E with #35750, I realized otlp_v1 is still treated as an invalid record type because it's missing from the unmarshalers map.

This PR is to add it into the map, enhance the error message output to show the record_type and add a test yaml file.

@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 1, 2024
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi merged commit 58c0120 into open-telemetry:main Nov 4, 2024
157 of 158 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 4, 2024
@kaiyan-sheng kaiyan-sheng deleted the fix_otlp_v1_type branch November 4, 2024 14:28
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…pen-telemetry#36125)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

After able to test E2E with
open-telemetry#35750,
I realized `otlp_v1` is still treated as an invalid record type because
it's missing from the unmarshalers map.

This PR is to add it into the map, enhance the error message output to
show the `record_type` and add a test yaml file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/awsfirehose Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants