Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(internal/otelarrow) Fix an e2e test flake #36138

Closed
wants to merge 1 commit into from
Closed

(internal/otelarrow) Fix an e2e test flake #36138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion internal/otelarrow/test/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,12 +324,20 @@ func standardEnding(t *testing.T, params testParams, testCon *testConsumer, expe
for _, span := range testCon.expSpans.GetSpans() {
eops[fmt.Sprintf("%v/%v", span.Name, span.Status.Code)]++

// This span has a recognized span error which we can't easily fix. See
// This span has a recognized span error which we
// can't easily fix related to the way Canceled status
// are treated by otel-grpc instrumentation. See
// https://github.com/open-telemetry/opentelemetry-go-contrib/issues/2644
if span.Name == "opentelemetry.proto.experimental.arrow.v1.ArrowTracesService/ArrowTraces" {
continue
}

// Note we also expect to see EOF errors. The
// requests that see EOF are retried.
if span.Status.Code == otelcodes.Error &&
span.Name == "otel_arrow_stream_send" && span.Status.Description == "EOF" {
continue
}
require.NotEqual(t, otelcodes.Error, span.Status.Code,
"Exporter span has error: %v: %v", span.Name, span.Status.Description)
}
Expand All @@ -340,6 +348,14 @@ func standardEnding(t *testing.T, params testParams, testCon *testConsumer, expe
continue
}

// For the admission control Note we also expect to see EOF errors. The
// requests that see EOF are retried.
if span.Status.Code == otelcodes.Error &&
span.Name == "otel_arrow_stream_inflight" &&
span.Status.Description == "rejecting request, too much pending data" {
continue
}

require.NotEqual(t, otelcodes.Error, span.Status.Code,
"Receiver span has error: %v: %v", span.Name, span.Status.Description)
}
Expand Down