(otelarrowreceiver): LIFO-based admission control, waiting limit expressed in MiB of request data #36141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essed in MiB of request data
…tor-contrib into jmacd/redo_36033_except_admission
mwear
approved these changes
Nov 12, 2024
mwear
approved these changes
Nov 13, 2024
moh-osman3
approved these changes
Nov 13, 2024
RutvikS-crest
pushed a commit
to RutvikS-crest/opentelemetry-collector-contrib
that referenced
this pull request
Dec 9, 2024
…essed in MiB of request data (open-telemetry#36141)
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…essed in MiB of request data (open-telemetry#36141)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the FIFO-based admission controller with a LIFO-based admission controller.
See https://medium.com/swlh/fifo-considered-harmful-793b76f98374 for an explanation.
Replaces the ineffective configuration
waiting_limitwith a replacement feature,waiting_limit_mibbased on the number of bytes waiting.This depends on merging #36140. See #36140 (comment).
Note that this PR keeps the new package name
admission2and deletes the old package namedadmission. This makes for a smaller change to review. It will be a trivial change to rename admission2 to admission in a separate PR.Link to tracking issue
Fixes #36074.
Testing
Existing tests were added in preparation for this step, see #36081.
Documentation
✅