Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confmap/provider/parameterstore] add new confmap provider for AWS SSM ParameterStore #36384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[confmap/provider/parameterstore] add new confmap provider for AWS SSM ParameterStore #36384

wants to merge 2 commits into from
+791 −0

Conversation

its-felix
Copy link

@its-felix its-felix commented Nov 15, 2024 •
edited
Loading

Description

Implements a confmap provider for AWS SSM ParameterStore

Link to tracking issue

Resolves #36383

Testing

  • Added test variants for both ARN and Name requests
  • Added test variants for JSON values
  • Both of the above together
  • All testcases ensure the correct parameters are passed to SSM

Documentation

Added README similar to that provided for secretsmanager describing the use of this provider

@its-felix its-felix requested a review from a team as a code owner November 15, 2024 04:12
@its-felix its-felix requested a review from ChrsMark November 15, 2024 04:12
@atoulme atoulme added the Sponsor Needed New component seeking sponsor label Nov 16, 2024
@its-felix its-felix changed the title add support for AWS SSM parameterstore [confmap/provider/parameterstore] add new confmap provider for AWS SSM ParameterStore Nov 16, 2024
@its-felix its-felix mentioned this pull request Nov 17, 2024
Open
@its-felix its-felix force-pushed the main branch 6 times, most recently from 1e7a6d6 to 8d510c2 Compare November 23, 2024 02:58
@its-felix its-felix force-pushed the main branch 2 times, most recently from 6aec64f to f6d8c6c Compare November 28, 2024 21:35
@its-felix
Copy link
Author

@driverpt @atoulme pulling you in as you are the owners for the SecretsManagerProvider.

Would you be open to sponsor this or take ownership?

@its-felix
Copy link
Author

its-felix commented Dec 17, 2024 •
edited
Loading

Related: #19368
aws-observability/aws-otel-collector#1894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

At least 1 approving review is required to merge this pull request.

Assignees

@bogdandrutu bogdandrutu

Labels
Sponsor Needed New component seeking sponsor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New confmap provider: AWS SSM ParameterStore
3 participants
@its-felix @atoulme @bogdandrutu