Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ottl): Add a new ottl trim function that trims leading and trailing whitespace from a string #36400
base: main
Are you sure you want to change the base?
feat(ottl): Add a new ottl trim function that trims leading and trailing whitespace from a string #36400
Changes from 3 commits
b2c24fd
d088773
5f20a1d
8a4dc98
1d8e1dd
5167e4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above line 34, lets to a check for if
replacement == ""
and error if it is. CallingTrim(name, "")
implies a nop, but we'd be trimming" "
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerHelmuth isn't an empty replacement string expected since the argument is optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm saying we shouldn't allow a user to set the optional parameter to be "".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IsEmpty returns false if the user sets the optional parameter to any value I thought, even default values like "".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
replacement.isEmpty()
returns false with a default value of""
for thereplacementString
.However, the replacementString is set to
""
under two conditions""
)replacementString
is explicitly set to""
If we return an error when the
replacementString
is set to""
, we would then make it a mandatory parameterI've pushed a commit such that when the replacementString is set to
""
in either of the above conditions, there is no effect on the original string (default behavior).