Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Configure renovate to update golang version #36483

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[chore] Configure renovate to update golang version #36483

wants to merge 5 commits into from

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 21, 2024 •
edited
Loading

Automated PR updating the dependency on fork odubajDT#2

Resolves: #36484

@github-actions github-actions bot added the exporter/datadog Datadog components label Nov 21, 2024
@odubajDT odubajDT marked this pull request as ready for review November 21, 2024 12:03
@odubajDT odubajDT requested a review from a team as a code owner November 21, 2024 12:03
odubajDT
odubajDT commented Nov 21, 2024
View reviewed changes
renovate.json Outdated Show resolved Hide resolved
odubajDT
odubajDT commented Nov 21, 2024
View reviewed changes
renovate.json Show resolved Hide resolved
odubajDT
odubajDT commented Nov 21, 2024
View reviewed changes
renovate.json Show resolved Hide resolved
@songy23 songy23 added dependencies Pull requests that update a dependency file ci-cd CI, CD, testing, build issues and removed exporter/datadog Datadog components labels Nov 21, 2024
codeboten
codeboten reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @odubajDT, is it possible to configure renovate to not bump the major version of go? we tend to test the older version we support in this repo

I suppose we could review whether or not that makes sense moving forward, wdyt?

@odubajDT
Copy link
Contributor Author

Thanks @odubajDT, is it possible to configure renovate to not bump the major version of go? we tend to test the older version we support in this repo

I suppose we could review whether or not that makes sense moving forward, wdyt?

Hey, under major version you understand 1.23 to potentially 1.24? I guess it does not hurt if PR is created for such an update, it won't be merged without a PR review and approval.

If you want to test it, you can just checkout the create PR locally and do all the tests that you need. The renovate should just make our lives easier by providing the PR for version bump when new version is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@bogdandrutu bogdandrutu

Labels
ci-cd CI, CD, testing, build issues dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure renovate to update go version automatically in github workflows
4 participants
@odubajDT @codeboten @bogdandrutu @songy23