Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Merge *.geo.location.{lat,lon} to *.geo.location in OTel mode #36594

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Nov 28, 2024

Description

In OTel mapping mode, merge *.geo.location.{lat,lon} to *.geo.location such that they are stored as geo_point in Elasticsearch.

Link to tracking issue

Fixes #36565

Testing

Documentation

@carsonip carsonip changed the title [exporter/elasticsearch] Merge geo.location.{lat,lon} to geo.location [exporter/elasticsearch] Merge *.geo.location.{lat,lon} to *.geo.location Nov 29, 2024
@carsonip carsonip changed the title [exporter/elasticsearch] Merge *.geo.location.{lat,lon} to *.geo.location [exporter/elasticsearch] Merge *.geo.location.{lat,lon} to *.geo.location in OTel mode Nov 29, 2024
Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.chloggen/elasticsearchexporter_merge-geo-location.yaml Outdated Show resolved Hide resolved
@andrzej-stencel andrzej-stencel merged commit 91cde84 into open-telemetry:main Dec 5, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 5, 2024
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this pull request Dec 5, 2024
…tion in OTel mode (open-telemetry#36594)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

In OTel mapping mode, merge *.geo.location.{lat,lon} to *.geo.location
such that they are stored as
[geo_point](https://www.elastic.co/guide/en/elasticsearch/reference/current/geo-point.html)
in Elasticsearch.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36565

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Vishal Raj <[email protected]>
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
…tion in OTel mode (open-telemetry#36594)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

In OTel mapping mode, merge *.geo.location.{lat,lon} to *.geo.location
such that they are stored as
[geo_point](https://www.elastic.co/guide/en/elasticsearch/reference/current/geo-point.html)
in Elasticsearch.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36565

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Vishal Raj <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…tion in OTel mode (open-telemetry#36594)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

In OTel mapping mode, merge *.geo.location.{lat,lon} to *.geo.location
such that they are stored as
[geo_point](https://www.elastic.co/guide/en/elasticsearch/reference/current/geo-point.html)
in Elasticsearch.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36565

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Vishal Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/elasticsearch] Encode geo location attributes as geo_point in Elasticsearch
5 participants