Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add statsdreceiver Unixgram Support #36608

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add statsdreceiver Unixgram Support #36608

wants to merge 12 commits into from
+204 −64

Conversation

michaelli321
Copy link

@michaelli321 michaelli321 commented Dec 1, 2024 •
edited
Loading

Description

Adds unixgram transport for the statsdreceiver. Additionally, creates a new packetServer base class for both UDS and UDP* transport types

Link to tracking issue

#21385

Testing

Added a unit test

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 1, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the receiver/statsd statsd related issues label Dec 1, 2024
@github-actions github-actions bot requested review from dmitryax and jmacd December 1, 2024 17:16
@michaelli321 michaelli321 mentioned this pull request Dec 1, 2024
Open
@michaelli321 michaelli321 marked this pull request as ready for review December 1, 2024 18:42
@michaelli321 michaelli321 requested a review from a team as a code owner December 1, 2024 18:42
@michaelli321 michaelli321 requested a review from dmitryax December 1, 2024 21:08
@michaelli321
Copy link
Author

@ChrsMark @jmacd @dmitryax Do you have an estimate on when someone could get around to a review?

ChrsMark
ChrsMark reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the enhancement looks good but I left some comments with things we should consider/tackle before merge.

@dmitryax @jmacd PTAL

receiver/statsdreceiver/internal/transport/client/client.go Show resolved Hide resolved
receiver/statsdreceiver/internal/transport/uds_server.go Outdated Show resolved Hide resolved
receiver/statsdreceiver/internal/transport/udp_server.go Show resolved Hide resolved
receiver/statsdreceiver/receiver.go Show resolved Hide resolved
dmitryax
dmitryax reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. Waiting for a conclusion the socket file discussion

ChrsMark
ChrsMark approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left one minor clarification question for the docs.

receiver/statsdreceiver/README.md Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Open
@ChrsMark
Copy link
Member

The code looks good to me. Waiting for a conclusion the socket file discussion

@dmitryax the socket deletion was removed, please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@ChrsMark ChrsMark

Labels
receiver/statsd statsd related issues waiting-for-code-owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelli321 @ChrsMark @dmitryax