[fix][googlecloudmonitoringreceiver]: remove creds check #36648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
requested review from
dashpole,
TylerHelmuth and
a team
as code owners
dashpole
approved these changes
Dec 3, 2024
mauri870
approved these changes
Dec 3, 2024
dashpole
added
the
ready to merge
codeboten
approved these changes
Dec 4, 2024
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…try#36648) #### Description Fix "no validation found" error if workload is running on Google Cloud Platform. There's no need to check for `creds` or `creds.JSON` explicitly. If any errors are encountered, it will be thrown by `FindDefaultCredentials`. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36607
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…try#36648) #### Description Fix "no validation found" error if workload is running on Google Cloud Platform. There's no need to check for `creds` or `creds.JSON` explicitly. If any errors are encountered, it will be thrown by `FindDefaultCredentials`. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36607
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…try#36648) #### Description Fix "no validation found" error if workload is running on Google Cloud Platform. There's no need to check for `creds` or `creds.JSON` explicitly. If any errors are encountered, it will be thrown by `FindDefaultCredentials`. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix "no validation found" error if workload is running on Google Cloud Platform.
There's no need to check for
credsorcreds.JSONexplicitly. If any errors are encountered, it will be thrown byFindDefaultCredentials.Link to tracking issue
Fixes #36607