[connector/signaltometrics]Add config validation and custom ottl funcs #36671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
commented
Dec 4, 2024
ChrsMark
reviewed
Dec 4, 2024
ChrsMark
added
the
ready to merge
atoulme
removed
the
ready to merge
|
This change requires a changelog entry. |
|
@atoulme Thanks for the review. I initially didn't add the changelog since the changes are related to a new component which is still in development (so not usable yet) and my reasoning was that the changelog will not be useful. I have added it now, please take a look. |
|
Since the changelog is now added I think this one can go. Marking this as |
ChrsMark
added
the
ready to merge
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
open-telemetry#36671) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds config validation logic and custom OTTL functions required for signal to metrics connector. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to: open-telemetry#35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Uni tests added. <!--Describe the documentation added.--> #### Documentation N/A <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds config validation logic and custom OTTL functions required for signal to metrics connector.
Link to tracking issue
Related to: #35930
Testing
Uni tests added.
Documentation
N/A